Repository navigation
Decode RGB9E5 inputs in failed upscale fallbacks - #425
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
When an upscale network fails to translate on AMD, entering Kokiri or changing dynamic resolution can turn the scene into bright neon colors.
Why merge
Change
gpu/vk/vk_draw.cpp: share the existing typed helper and use it for compatible RGB9E5 fallback inputs.tests/test_upscale_fallback.py: exercise the actual fallback function across 13 routing and capability cases without Vulkan.Tested
python -I -B tests/test_upscale_fallback.py --cxx clang++checks the routing and unsupported-feature fallbacks. Fails on the old code, passes now.Not covered